-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend) Allow overriding akka-max-header-value-length #5094
feat(frontend) Allow overriding akka-max-header-value-length #5094
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you!
cc @RyanHolstien to take a quick look as well.
This setting is already exposed as configurable through the play configuration. Instead of modifying the custom configurations, please just add a variable setting |
Let's try what @RyanHolstien has suggested - if its possible, we can make that change and should be good to merge! If there's any issue, let us know. |
70c7563
to
bf982a9
Compare
@RyanHolstien was looking at docs for 2.7.6 and it seems like the setting should be |
bf982a9
to
0a3498e
Compare
@karoliskascenas Yes this looks right! Sorry for putting the wrong variable name in my previous comment. |
Will merge once this passes CI. |
Setting the docker container's env variable Edit: found the answer. Setting |
Allows overriding
max-header-value-length
via environment variables. This should enable users to solve the following issue:akka.actor.ActorSystemImpl - Illegal request, responding with status '431 Request Header Fields Too Large': HTTP header value exceeds the configured limit of 8192 characters