Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(graphql): add graphql endpoint to check whether an entity exists #5102

Merged
merged 3 commits into from
Jun 7, 2022
Merged

feat(graphql): add graphql endpoint to check whether an entity exists #5102

merged 3 commits into from
Jun 7, 2022

Conversation

aditya-radhakrishnan
Copy link
Contributor

@aditya-radhakrishnan aditya-radhakrishnan commented Jun 7, 2022 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

github-actions bot commented Jun 7, 2022 •
edited
Loading

Unit Test Results (build & test)

341 tests  +2   341 ✔️ +2   3m 8s ⏱️ -1s
  83 suites +1       0 💤 ±0 
  83 files   +1       0 ❌ ±0 

Results for commit d74bb1a. ± Comparison against base commit 031b10c.

♻️ This comment has been updated with latest results.

jjoyce0510
jjoyce0510 reviewed Jun 7, 2022
View reviewed changes
datahub-graphql-core/src/main/resources/entity.graphql Outdated
"""
Get whether or not not an entity exists
"""
getDoesEntityExist(urn: String!): Boolean
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still has wrong name!

jjoyce0510
jjoyce0510 approved these changes Jun 7, 2022
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@jjoyce0510 jjoyce0510 merged commit e97fa83 into datahub-project:master Jun 7, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@aditya-radhakrishnan @maggiehays
feat(graphql): add graphql endpoint to check whether an entity exists (…
fe4842a 
…datahub-project#5102)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

@gabe-lyons gabe-lyons gabe-lyons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aditya-radhakrishnan @gabe-lyons @jjoyce0510