Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): pin google-cloud-logging to avoid pip backtracking #5109

Merged

Conversation

shirshanka
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Copy link
Collaborator

@anshbansal anshbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@anshbansal anshbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In https://github.com/datahub-project/datahub/pull/5108/files I removed the protobuf dependency. You will need to merge latest master, add protobuf constraint back on top else bigquery connector will fail again

@github-actions
Copy link

github-actions bot commented Jun 7, 2022

Unit Test Results (build & test)

339 tests  ±0   339 ✔️ ±0   3m 3s ⏱️ -15s
  82 suites ±0       0 💤 ±0 
  82 files   ±0       0 ±0 

Results for commit fca96e7. ± Comparison against base commit 596853a.

♻️ This comment has been updated with latest results.

@shirshanka shirshanka force-pushed the pin-deps-on-google-logging branch from 115c7dc to fca96e7 Compare June 7, 2022 16:49
Copy link
Collaborator

@anshbansal anshbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anshbansal anshbansal merged commit 51854a7 into datahub-project:master Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants