Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schema): support rendering schemas with . in field names #5141

Merged
merged 3 commits into from
Jun 10, 2022

Conversation

gabe-lyons
Copy link
Contributor

We used to tokenize field names by . when rendering. This updates the logic to instead truncate based on the parent's path.

For example, here is a looker dataset rendering properly:
image

and a nested dataset:
image

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

Unit Test Results (build & test)

381 tests  ±0   381 ✔️ ±0   3m 23s ⏱️ -1s
  89 suites ±0       0 💤 ±0 
  89 files   ±0       0 ±0 

Results for commit c4f7bd5. ± Comparison against base commit e6b66d8c.

@anshbansal anshbansal merged commit 1b50709 into datahub-project:master Jun 10, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants