Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui): Misc improvements to Dataset Assertions UI #5155

Merged
merged 12 commits into from
Jun 14, 2022

Conversation

jjoyce0510
Copy link
Collaborator

@jjoyce0510 jjoyce0510 commented Jun 13, 2022

Summary

This PR fixes and improves various aspects of the Assertions UI, including:

  1. If you have no assertion runs, you will not see a pass or fail status next to dataset name
  2. Default to the assertions tab when assertions are present (do not require an extra click)
  3. Support viewable logic along with an assertion definition (in a logic modal)
  4. Fix inconsistent remove assertions flow

Screenshots

Screen Shot 2022-06-13 at 2 56 25 PM

Screen Shot 2022-06-13 at 2 56 43 PM

Screen Shot 2022-06-13 at 2 56 48 PM

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

github-actions bot commented Jun 13, 2022

Unit Test Results (build & test)

381 tests  ±0   381 ✔️ ±0   2m 54s ⏱️ -9s
  89 suites ±0       0 💤 ±0 
  89 files   ±0       0 ±0 

Results for commit 51b93b5. ± Comparison against base commit 38718b5.

♻️ This comment has been updated with latest results.

@jjoyce0510 jjoyce0510 merged commit 7c46437 into datahub-project:master Jun 14, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants