Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(docs): Update Metadata Events Docs #5173

Merged
merged 9 commits into from
Jun 17, 2022
Merged

refactor(docs): Update Metadata Events Docs #5173

merged 9 commits into from
Jun 17, 2022

Conversation

jjoyce0510
Copy link
Collaborator

@jjoyce0510 jjoyce0510 commented Jun 14, 2022 •
edited
Loading

Many improvements to docs involving any of the critical Kafka events used by DataHub, including:

  • metadata serving overview
  • kafka configuration doc
  • confluent integration doc
  • architecture overview
  • most importantly, the mxe doc

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

Unit Test Results (build & test)

382 tests  ±0   382 ✔️ +2   8m 46s ⏱️ -1s
  89 suites ±0       0 💤 ±0 
  89 files   ±0       0 ❌  - 2 

Results for commit b6fb233. ± Comparison against base commit af0e348.

treff7es
treff7es approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jjoyce0510 jjoyce0510 merged commit 6bc29e6 into datahub-project:master Jun 17, 2022
alexey-kravtsov pushed a commit to infobip/datahub that referenced this pull request Jul 8, 2022
@jjoyce0510 @alexey-kravtsov
refactor(docs): Update Metadata Events Docs (datahub-project#5173)
d125830
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@jjoyce0510 @maggiehays
refactor(docs): Update Metadata Events Docs (datahub-project#5173)
739ef24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjoyce0510 @treff7es