Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(glue): fix glue profiling config option #5178

Conversation

kangseonghyun
Copy link
Contributor

I am trying to modify the line because it seems strange to check the row_count value when allocating the column_count value.

Please let me know if there is anything I'm doing wrong

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

Unit Test Results (build & test)

381 tests  ±0   381 ✔️ ±0   3m 58s ⏱️ +15s
  89 suites ±0       0 💤 ±0 
  89 files   ±0       0 ±0 

Results for commit 0fe8987. ± Comparison against base commit b4bf1d4.

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       5 files         5 suites   1h 27m 35s ⏱️
   555 tests    552 ✔️   3 💤 0
2 552 runs  2 477 ✔️ 75 💤 0

Results for commit 0fe8987.

Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit f4674c3 into datahub-project:master Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants