feat(upgrade) Check version when determining to run RestoreGlossaryIndices step #5182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would only check that the datahub upgrade urn existed for the restore glossary indices step to determine if we should run the step. If it existed we did not run, and if not, we ran it.
Now, we may have situations where someone may have run the upgrade step but we want them to run it again, so we can check a version! The
DataHubUpgradeRequest
aspect was already storing a version, and for this step we previously set it to0
. Now we check to get that aspect, and if it exists, and it has the same version as the const at the top of the file, skip the step. If it doesn't exist or the version is different, run the step.Now to have users re-run the step we just need to change the
VERSION
at the top of the file. I do so here as we know we want some users to re-run this step.Adds a new test for running with a new version (the diff looks confusing there)
Checklist