Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(ingest): correct case of sys views for mssql description populati… #5186

Merged
merged 1 commit into from
Jun 17, 2022
Merged

bug(ingest): correct case of sys views for mssql description populati… #5186

merged 1 commit into from
Jun 17, 2022

Conversation

BALyons
Copy link
Contributor

@BALyons BALyons commented Jun 16, 2022 •
edited
Loading

…on (#5181)

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

Unit Test Results (build & test)

381 tests  ±0   381 ✔️ ±0   3m 59s ⏱️ +10s
  89 suites ±0       0 💤 ±0 
  89 files   ±0       0 ❌ ±0 

Results for commit c35e5cd. ± Comparison against base commit f4674c3.

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       5 files         5 suites   1h 38m 24s ⏱️
   555 tests    552 ✔️   3 💤 0 ❌
2 552 runs  2 477 ✔️ 75 💤 0 ❌

Results for commit c35e5cd.

chriscollins3456
chriscollins3456 approved these changes Jun 17, 2022
View reviewed changes
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! thanks for linking the issue as well.

@anshbansal anshbansal merged commit e360d26 into datahub-project:master Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriscollins3456 chriscollins3456 chriscollins3456 approved these changes

@anshbansal anshbansal anshbansal approved these changes

Assignees

@chriscollins3456 chriscollins3456

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BALyons @anshbansal @chriscollins3456