fix(ui): load monaco-editor as a dependency and not from a third party CDN #5189
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the monaco-editor as a dependency and loads the editor from the local directory and not from a third party CDN. This fixes potential issues where the CDN is not reachable (see also #4955) and of course it is better to have all dependencies in one place and not relying on a third party service.
As it is quite hard (to not say impossible?) to import the monaco-editor in a Create React App (there are many issues, comments, etc. which describes the issues with it), the files are copied from the monaco-editor package to the build directory using the CopyWebpackPlugin and are then loaded by the @monaco-editor/react package from there.
The version of the added monaco-editor package is exactly the version which is loaded by the current version of the @monaco-editor/react package, therefore there shouldn't be any differences.
Checklist