Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ingestion): bigquery-usage - Adding tests for bigquery usage filters #5195

Merged
merged 3 commits into from
Jun 21, 2022
Merged

test(ingestion): bigquery-usage - Adding tests for bigquery usage filters #5195

merged 3 commits into from
Jun 21, 2022

Conversation

treff7es
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       6 files  +    1         6 suites  +1   1h 11m 9s ⏱️ - 31m 1s
   558 tests +    2     555 ✔️ +    2    3 💤 ±0  0 ❌ ±0 
2 000 runs   - 557  1 928 ✔️  - 554  72 💤  - 3  0 ❌ ±0 

Results for commit 159e1ce. ± Comparison against base commit b0db17e.

@github-actions
Copy link

Unit Test Results (build & test)

382 tests  ±0   382 ✔️ ±0   9m 4s ⏱️ +2s
  89 suites ±0       0 💤 ±0 
  89 files   ±0       0 ❌ ±0 

Results for commit 159e1ce. ± Comparison against base commit b0db17e.

shirshanka
shirshanka approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 393c07e into datahub-project:master Jun 21, 2022
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Jun 22, 2022
@treff7es @shirshanka
refactor(ingest): bigquery-usage - Adding tests for bigquery usage fi…
e3883ae 
…lters (datahub-project#5195)
alexey-kravtsov pushed a commit to infobip/datahub that referenced this pull request Jul 8, 2022
@treff7es @alexey-kravtsov
refactor(ingest): bigquery-usage - Adding tests for bigquery usage fi…
f2eeee9 
…lters (datahub-project#5195)
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@treff7es @maggiehays
refactor(ingest): bigquery-usage - Adding tests for bigquery usage fi…
b72996d 
…lters (datahub-project#5195)
@treff7es treff7es deleted the add_test_for_bq_usage_filters branch February 8, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@treff7es @shirshanka