Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tableau): use pagination for all connection queries #5204

Merged
merged 2 commits into from
Jun 22, 2022
Merged

feat(tableau): use pagination for all connection queries #5204

merged 2 commits into from
Jun 22, 2022

Conversation

mayurinehate
Copy link
Collaborator

@mayurinehate mayurinehate commented Jun 20, 2022 •
edited
Loading

Currently only workbooksConnection query is paginated using config workbooks_page_size. This PR introduces page_size config for all metadata queries (including customSQLTablesConnection, publishedDatasourcesConnection) in order to overcome NODE_LIMIT_EXCEEDED error and deprecates workbooksConnection specific workbooks_page_size config.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

github-actions bot commented Jun 20, 2022 •
edited
Loading

Unit Test Results (build & test)

385 tests  ±0   385 ✔️ ±0   10m 12s ⏱️ ±0s
  91 suites ±0       0 💤 ±0 
  91 files   ±0       0 ❌ ±0 

Results for commit 95c17af. ± Comparison against base commit 393c07e.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jun 20, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   1h 18m 15s ⏱️ - 1m 48s
   565 tests ±0     562 ✔️ ±0    3 💤 ±0  0 ❌ ±0 
1 068 runs  ±0  1 025 ✔️ ±0  43 💤 ±0  0 ❌ ±0 

Results for commit 95c17af. ± Comparison against base commit 393c07e.

♻️ This comment has been updated with latest results.

jjoyce0510
jjoyce0510 approved these changes Jun 21, 2022
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mayurinehate mayurinehate marked this pull request as ready for review June 22, 2022 13:54
@jjoyce0510 jjoyce0510 merged commit 022ef2f into datahub-project:master Jun 22, 2022
alexey-kravtsov pushed a commit to infobip/datahub that referenced this pull request Jul 8, 2022
@mayurinehate @alexey-kravtsov
feat(tableau): use pagination for all connection queries (datahub-pro…
fc01f3d 
…ject#5204)
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@mayurinehate @maggiehays
feat(tableau): use pagination for all connection queries (datahub-pro…
2af6d21 
…ject#5204)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mayurinehate @jjoyce0510