Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dbt-test): Inconsistency in assertions #5214

Merged
merged 3 commits into from
Jun 23, 2022
Merged

fix(dbt-test): Inconsistency in assertions #5214

merged 3 commits into from
Jun 23, 2022

Conversation

Santhin
Copy link
Contributor

@Santhin Santhin commented Jun 21, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Fixes: #5213

@shirshanka shirshanka self-assigned this Jun 21, 2022
@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files         8 suites   1h 19m 4s ⏱️
   576 tests    572 ✔️   3 💤 1 ❌
1 090 runs  1 046 ✔️ 43 💤 1 ❌

For more details on these failures, see this check.

Results for commit 2ea4213.

@github-actions
Copy link

Unit Test Results (build & test)

389 tests  ±0   389 ✔️ ±0   10m 23s ⏱️ -30s
  92 suites ±0       0 💤 ±0 
  92 files   ±0       0 ❌ ±0 

Results for commit 2ea4213. ± Comparison against base commit 6b82a0b.

shirshanka
shirshanka approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 9f2b3b9 into datahub-project:master Jun 23, 2022
alexey-kravtsov pushed a commit to infobip/datahub that referenced this pull request Jul 8, 2022
@Santhin @PiotrSierkin-Ki
@shirshanka @alexey-kravtsov
fix(ingest): dbt - make assertion display names consistent (datahub-p…
568e27d 
…roject#5214)

Co-authored-by: Piotr Sierkin <[email protected]>
Co-authored-by: Shirshanka Das <[email protected]>
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@Santhin @PiotrSierkin-Ki
@shirshanka @maggiehays
fix(ingest): dbt - make assertion display names consistent (datahub-p…
40f5a6c 
…roject#5214)

Co-authored-by: Piotr Sierkin <[email protected]>
Co-authored-by: Shirshanka Das <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees

@shirshanka shirshanka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistency in the naming of assertions (dbt-test/dbt-expectations)
3 participants
@Santhin @shirshanka @PiotrSierkin-Ki