Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary space from application.yml of GMS #5216

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

mmmeeedddsss
Copy link
Contributor

There was an extra space in the application.yml file on the definition of elasticsearch.index.numRetries. Even we couldn't see that this cause any issue, we still wanted to make a change for the consistency in the format of the file.

See a broader context from the slack thread around an issue we have with overriding the elasticsearch.index.numRetries config by passing the env var ELASTICSEARCH_INDEX_BUILDER_NUM_RETRIES

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

Unit Test Results (build & test)

385 tests  ±0   385 ✔️ ±0   11m 8s ⏱️ +55s
  91 suites ±0       0 💤 ±0 
  91 files   ±0       0 ±0 

Results for commit 58c513c. ± Comparison against base commit 648ebfc.

@aditya-radhakrishnan aditya-radhakrishnan self-requested a review June 21, 2022 21:55
Copy link
Contributor

@aditya-radhakrishnan aditya-radhakrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you so much!

@dexter-mh-lee dexter-mh-lee merged commit e4921ee into datahub-project:master Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants