Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for 0 rows when profiling datasets from s3 #5219

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Add check for 0 rows when profiling datasets from s3 #5219

merged 1 commit into from
Jun 23, 2022

Conversation

Jiafi
Copy link
Contributor

@Jiafi Jiafi commented Jun 21, 2022 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   1h 19m 53s ⏱️ + 2m 30s
   565 tests ±0     562 ✔️ +1    3 💤 ±0  0 ❌  - 1 
1 068 runs  ±0  1 025 ✔️ +1  43 💤 ±0  0 ❌  - 1 

Results for commit 8a372b4. ± Comparison against base commit 648ebfc.

@github-actions
Copy link

Unit Test Results (build & test)

385 tests  ±0   385 ✔️ ±0   10m 18s ⏱️ +5s
  91 suites ±0       0 💤 ±0 
  91 files   ±0       0 ❌ ±0 

Results for commit 8a372b4. ± Comparison against base commit 648ebfc.

treff7es
treff7es approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the fix

@treff7es treff7es merged commit 2be1e64 into datahub-project:master Jun 23, 2022
alexey-kravtsov pushed a commit to infobip/datahub that referenced this pull request Jul 8, 2022
@Jiafi @alexey-kravtsov
fix(ingest): s3 - add check for 0 rows in profiling (datahub-project#…
4540960 
…5219)
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@Jiafi @maggiehays
fix(ingest): s3 - add check for 0 rows in profiling (datahub-project#…
ca74d1b 
…5219)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees

@MugdhaHardikar-GSLab MugdhaHardikar-GSLab

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jiafi @treff7es @MugdhaHardikar-GSLab