fix(ingest): databricks - ingest structs correctly through hive #5223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurinehate
approved these changes
Jun 22, 2022
| pass | ||
| except Exception as e: | ||
| logger.warning(f"Failed to patch method due to {e}") | ||
| pass |
There was a problem hiding this comment.
No need of pass here. Everything else looks good to me.
|
fixes #5194 |
alexey-kravtsov
pushed a commit
to infobip/datahub
that referenced
this pull request
Jul 8, 2022
maggiehays
pushed a commit
to maggiehays/datahub
that referenced
this pull request
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default dbapi implementation doesn't pass through struct types.
This PR patches that function to pass it through.
Checklist