Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): pin confluent kafka dependency #5224

Merged
merged 2 commits into from
Jun 22, 2022
Merged

fix(build): pin confluent kafka dependency #5224

merged 2 commits into from
Jun 22, 2022

Conversation

anshbansal
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

treff7es
treff7es approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   1h 17m 52s ⏱️ +41s
   576 tests ±0     572 ✔️  - 1    3 💤 ±0  1 ❌ +1 
1 090 runs  ±0  1 046 ✔️  - 1  43 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 87c49d8. ± Comparison against base commit 82ca92f.

@github-actions
Copy link

Unit Test Results (build & test)

385 tests  ±0   385 ✔️ ±0   10m 3s ⏱️ -8s
  91 suites ±0       0 💤 ±0 
  91 files   ±0       0 ❌ ±0 

Results for commit 87c49d8. ± Comparison against base commit 82ca92f.

@anshbansal anshbansal merged commit 8c8f1b9 into datahub-project:master Jun 22, 2022
@anshbansal anshbansal deleted the pin-confluent-kafka branch June 22, 2022 08:23
alexey-kravtsov pushed a commit to infobip/datahub that referenced this pull request Jul 8, 2022
@anshbansal @alexey-kravtsov
fix(build): pin confluent kafka dependency (datahub-project#5224)
49a5011
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@anshbansal @maggiehays
fix(build): pin confluent kafka dependency (datahub-project#5224)
6b117ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees

@treff7es treff7es

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshbansal @treff7es