Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug fix]: disabled create buttons #5234

Merged
merged 1 commit into from
Jun 23, 2022
Merged

[bug fix]: disabled create buttons #5234

merged 1 commit into from
Jun 23, 2022

Conversation

xiphl
Copy link
Contributor

@xiphl xiphl commented Jun 23, 2022

if you do not have the MANAGE DOMAINS privilege, the button to create new term/term group is grayed out:
image
It should have checked the MANAGE GLOSSARIES privilege instead.

@github-actions
Copy link

Unit Test Results (build & test)

389 tests  ±0   389 ✔️ ±0   10m 40s ⏱️ +22s
  92 suites ±0       0 💤 ±0 
  92 files   ±0       0 ±0 

Results for commit 749d75b. ± Comparison against base commit 2be1e64.

Copy link
Contributor

@aditya-radhakrishnan aditya-radhakrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jjoyce0510 jjoyce0510 merged commit 13d5734 into datahub-project:master Jun 23, 2022
@xiphl xiphl deleted the bug-fix-disabled-glossary-button branch June 23, 2022 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants