fix(docker): Fixing dev docker and quickstart

datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/config/AppConfigResolver.java

@@ -87,7 +87,7 @@ public CompletableFuture<AppConfig> get(final DataFetchingEnvironment environmen
     authConfig.setTokenAuthEnabled(_authenticationConfiguration.isEnabled());
 
     final PoliciesConfig policiesConfig = new PoliciesConfig();
-    policiesConfig.setEnabled(Boolean.TRUE.equals(_authorizationConfiguration.getDefaultAuthorizer().getEnabled()));
+    policiesConfig.setEnabled(_authorizationConfiguration.getDefaultAuthorizer().isEnabled());
 
     policiesConfig.setPlatformPrivileges(com.linkedin.metadata.authorization.PoliciesConfig.PLATFORM_PRIVILEGES
         .stream()

docker/datahub-gms/env/docker.env

@@ -70,4 +70,4 @@ UI_INGESTION_DEFAULT_CLI_VERSION=0.8.41
 # SECRET_SERVICE_ENCRYPTION_KEY=<your-AES-encryption-key>
 
 # Uncomment to increase concurrency across Kafka consumers
-# KAFKA_LISTENER_CONCURRENCY=2
+# KAFKA_LISTENER_CONCURRENCY=2

docker/docker-compose-without-neo4j.override.yml

@@ -28,7 +28,7 @@ services:
     env_file: datahub-gms/env/docker-without-neo4j.env
     environment:
       - DATAHUB_SERVER_TYPE=${DATAHUB_SERVER_TYPE:-quickstart}
-      - DATAHUB_TELEMETRY_ENABLED=${DATAHUB_TELEMETRY_ENABLED}
+      - DATAHUB_TELEMETRY_ENABLED=${DATAHUB_TELEMETRY_ENABLED:-true}
     depends_on:
       - mysql
     volumes:

docker/docker-compose.dev.yml

@@ -41,10 +41,6 @@ services:
       - SKIP_ELASTICSEARCH_CHECK=false
       - DATAHUB_SERVER_TYPE=${DATAHUB_SERVER_TYPE:-dev}
       - DATAHUB_TELEMETRY_ENABLED=${DATAHUB_TELEMETRY_ENABLED:-true}
-      - AUTH_POLICIES_ENABLED=${AUTH_POLICIES_ENABLED}
-      - RANGER_AUTHORIZER_ENABLED=${RANGER_AUTHORIZER_ENABLED}
-      - RANGER_USERNAME=${RANGER_USERNAME}
-      - RANGER_PASSWORD=${RANGER_PASSWORD}
     volumes:
       - ./datahub-gms/start.sh:/datahub/datahub-gms/scripts/start.sh
       - ./datahub-gms/jetty.xml:/datahub/datahub-gms/scripts/jetty.xml

docker/docker-compose.override.yml

@@ -32,10 +32,6 @@ services:
     environment:
       - DATAHUB_SERVER_TYPE=${DATAHUB_SERVER_TYPE:-quickstart}
       - DATAHUB_TELEMETRY_ENABLED=${DATAHUB_TELEMETRY_ENABLED:-true}
-      - AUTH_POLICIES_ENABLED=${AUTH_POLICIES_ENABLED}
-      - RANGER_AUTHORIZER_ENABLED=${RANGER_AUTHORIZER_ENABLED}
-      - RANGER_USERNAME=${RANGER_USERNAME}
-      - RANGER_PASSWORD=${RANGER_PASSWORD}
     volumes:
       - ${HOME}/.datahub/plugins/:/etc/datahub/plugins
       - ${HOME}/.datahub/plugins/auth/resources/:/etc/datahub/plugins/auth/resources

docker/quickstart/docker-compose-without-neo4j.quickstart.yml

@@ -64,7 +64,7 @@ services:
     - mysql
     environment:
     - DATAHUB_SERVER_TYPE=${DATAHUB_SERVER_TYPE:-quickstart}
-    - DATAHUB_TELEMETRY_ENABLED=${DATAHUB_TELEMETRY_ENABLED}
+    - DATAHUB_TELEMETRY_ENABLED=${DATAHUB_TELEMETRY_ENABLED:-true}
     - DATASET_ENABLE_SCSI=false
     - EBEAN_DATASOURCE_USERNAME=datahub
     - EBEAN_DATASOURCE_PASSWORD=datahub

docker/quickstart/docker-compose.quickstart.yml

@@ -66,10 +66,6 @@ services:
     environment:
     - DATAHUB_SERVER_TYPE=${DATAHUB_SERVER_TYPE:-quickstart}
     - DATAHUB_TELEMETRY_ENABLED=${DATAHUB_TELEMETRY_ENABLED:-true}
-    - AUTH_POLICIES_ENABLED=${AUTH_POLICIES_ENABLED}
-    - RANGER_AUTHORIZER_ENABLED=${RANGER_AUTHORIZER_ENABLED}
-    - RANGER_USERNAME=${RANGER_USERNAME}
-    - RANGER_PASSWORD=${RANGER_PASSWORD}
     - DATASET_ENABLE_SCSI=false
     - EBEAN_DATASOURCE_USERNAME=datahub
     - EBEAN_DATASOURCE_PASSWORD=datahub

metadata-service/auth-api/src/main/java/com/datahub/authorization/AuthorizerConfiguration.java

@@ -12,7 +12,7 @@ public class AuthorizerConfiguration {
   /**
    * Whether to enable this authorizer
    */
-  private Boolean enabled = false;
+  private boolean enabled;
   /**
    * A fully-qualified class name for the {@link Authorizer} implementation to be registered.
    */

metadata-service/auth-api/src/main/java/com/datahub/authorization/DefaultAuthorizerConfiguration.java

@@ -8,7 +8,7 @@ public class DefaultAuthorizerConfiguration {
   /**
    * Whether authorization via DataHub policies is enabled.
    */
-  private Boolean enabled;
+  private boolean enabled;
   /**
    * The duration between policies cache refreshes.
    */

metadata-service/factories/src/main/java/com/linkedin/gms/factory/auth/AuthorizerChainFactory.java

@@ -56,7 +56,7 @@ protected AuthorizerChain getInstance() {
     // Extract + initialize customer authorizers from application configs.
     final List<Authorizer> authorizers = new ArrayList<>(initCustomAuthorizers(ctx));
 
-    if (Boolean.TRUE.equals(configurationProvider.getAuthorization().getDefaultAuthorizer().getEnabled())) {
+    if (configurationProvider.getAuthorization().getDefaultAuthorizer().isEnabled()) {
       this.dataHubAuthorizer.init(Collections.emptyMap(), ctx);
       log.info("Default DataHubAuthorizer is enabled. Appending it to the authorization chain.");
       authorizers.add(this.dataHubAuthorizer);
@@ -81,8 +81,7 @@ private List<Authorizer> initCustomAuthorizers(AuthorizerContext ctx) {
       for (AuthorizerConfiguration authorizer : authorizerConfigurations) {
         final String type = authorizer.getType();
         // continue if authorizer is not enabled
-        // Boolean.FALSE.equals take care to map null to false and false to false
-        if (Boolean.FALSE.equals(authorizer.getEnabled())) {
+        if (!authorizer.isEnabled()) {
           log.info(String.format("Authorizer %s is not enabled", type));
           continue;
         }