fix(kafka-setup): Don't set truststore pass for PEM files #8656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
devops
maggiehays
added
the
community-contribution
leifker
approved these changes
Aug 27, 2023
david-leifker
approved these changes
Aug 27, 2023
david-leifker
added
the
merge-pending-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like PEM formatted keys for SSL connection to kafka causes the kafka client to complain about the existance of
ssl.truststore.password. In this PR, I'm adding a small condition to not setssl.truststore.passwordif the truststore type is PEM.Error is as follows:
Caused by: org.apache.kafka.common.errors.InvalidConfigurationException: SSL trust store password cannot be specified for PEM format.