Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/sagemaker): Adding option to control retry for any aws source #8727

Merged
merged 2 commits into from
Dec 7, 2024
Merged

fix(ingest/sagemaker): Adding option to control retry for any aws source #8727

merged 2 commits into from
Dec 7, 2024

Conversation

treff7es
Copy link
Contributor

  • Adding logs to make it transparent what is going on in SageMaker
  • Adding option to control retry for any aws source

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Aug 25, 2023
hsheth2
hsheth2 approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one tweak, but otherwise lgtm

metadata-ingestion/src/datahub/ingestion/source/aws/aws_common.py Outdated Show resolved Hide resolved
@hsheth2
Copy link
Collaborator

hsheth2 commented May 8, 2024

@treff7es looks like there's a lint issue + merge conflict here

@shirshanka shirshanka added the on-deck PR or Issue that will be reviewed and/or addressed by the DataHub Maintainers in future cycles label Jun 28, 2024
@treff7es
Adding option to control retry for any aws source
620e6e4 
Adding logs to make it transparent what is going on in SageMaker
@treff7es
Fixing mypy on 3.7
bcf56fb
@treff7es treff7es merged commit 1d5ddf0 into datahub-project:master Dec 7, 2024
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees

@treff7es treff7es

Labels
ingestion PR or Issue related to the ingestion of metadata on-deck PR or Issue that will be reviewed and/or addressed by the DataHub Maintainers in future cycles pending-submitter-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@treff7es @hsheth2 @shirshanka