Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix): Avoid java.util.ConcurrentModificationException #9090

Merged
merged 2 commits into from
Oct 26, 2023
Merged

(fix): Avoid java.util.ConcurrentModificationException #9090

merged 2 commits into from
Oct 26, 2023

Conversation

rtekal
Copy link
Contributor

@rtekal rtekal commented Oct 24, 2023 •
edited by pedro93
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

rtekal
rtekal commented Oct 24, 2023
View reviewed changes
metadata-service/auth-impl/src/main/java/com/datahub/authorization/DataHubAuthorizer.java
@@ -253,10 +273,13 @@ public void run() {
"Failed to retrieve policy urns! Skipping updating policy cache until next refresh. start: {}, count: {}", start, count, e);
return;
}
synchronized (_policyCache) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The synchronize doesn't have to be inside the while loop

@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Oct 24, 2023
@pedro93 pedro93 requested a review from david-leifker October 25, 2023 12:06
@pedro93
Copy link
Collaborator

pedro93 commented Oct 25, 2023

@rtekal thank you raising a PR.
To make our review process easier please update the PR's description & title as specified in https://github.com/datahub-project/datahub/blob/master/docs/CONTRIBUTING.md#commit-message-format
In particular please add a description detailing what this PR's objective is, how the solution was implemented and any caveats the reviewers should be aware off.

Have a great day!

@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 26, 2023
@david-leifker david-leifker merged commit 1ac831f into datahub-project:master Oct 26, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-leifker david-leifker david-leifker approved these changes

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rtekal @pedro93 @david-leifker @maggiehays