Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): add entity_supports_aspect helper #9120

Merged
merged 1 commit into from
Oct 30, 2023
Merged

feat(ingest): add entity_supports_aspect helper #9120

merged 1 commit into from
Oct 30, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Oct 26, 2023

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@hsheth2 hsheth2 mentioned this pull request Oct 26, 2023
Merged
5 tasks
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 27, 2023
@hsheth2 hsheth2 requested a review from asikowitz October 27, 2023 17:20
asikowitz
asikowitz approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@asikowitz asikowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty cool

@hsheth2 hsheth2 merged commit 0bd2d9a into datahub-project:master Oct 30, 2023
54 checks passed
@hsheth2 hsheth2 deleted the supports-aspect branch October 30, 2023 21:22
@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asikowitz asikowitz asikowitz approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsheth2 @asikowitz @maggiehays