Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/clickhouse): pin version to solve column reflection regression #9143

Merged
merged 1 commit into from
Oct 30, 2023
Merged

fix(ingest/clickhouse): pin version to solve column reflection regression #9143

merged 1 commit into from
Oct 30, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Oct 30, 2023

See xzkostyan/clickhouse-sqlalchemy#272

Example failure: https://github.com/datahub-project/datahub/actions/runs/6688931190/job/18171700309?pr=9123

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@hsheth2 hsheth2 requested a review from asikowitz October 30, 2023 18:16
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 30, 2023
@asikowitz
Copy link
Collaborator

I wonder if we could get away with a != instead of a <=... This is safer though

@hsheth2
Copy link
Collaborator Author

hsheth2 commented Oct 30, 2023

@asikowitz I'm not 100% sure they'll fix it in the next release, which is why I did a < instead of !=

@hsheth2 hsheth2 merged commit 58bcedc into datahub-project:master Oct 30, 2023
51 checks passed
@hsheth2 hsheth2 deleted the clickhouse-fix branch October 30, 2023 21:18
@hsheth2 hsheth2 mentioned this pull request Oct 30, 2023
Merged
5 tasks
@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asikowitz asikowitz asikowitz approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsheth2 @asikowitz @maggiehays