feat(neo4j): Allow datahub to connect to specific neo4j database #9179
Conversation
github-actions
bot
added
the
devops
| @@ -146,7 +146,7 @@ services: | |||
| - ELASTICSEARCH_INDEX_BUILDER_MAPPINGS_REINDEX=true | |||
| - ELASTICSEARCH_INDEX_BUILDER_SETTINGS_REINDEX=true | |||
| - ELASTICSEARCH_BUILD_INDICES_CLONE_INDICES=false | |||
| - GRAPH_SERVICE_IMPL=elasticsearch | |||
| - GRAPH_SERVICE_IMPL=neo4j | |||
There was a problem hiding this comment.
Lets not change the graph service impl here. If you'd like to make it configurable, it can be like GRAPH_SERVICE_IMPL=${GRAPH_SERVICE_IMPL:-elasticsearch} so that you can override the impl with an environment variable if that's your preferred quickstart backend.
There was a problem hiding this comment.
done. Please check
| @@ -146,7 +146,7 @@ services: | |||
| - ELASTICSEARCH_INDEX_BUILDER_MAPPINGS_REINDEX=true | |||
| - ELASTICSEARCH_INDEX_BUILDER_SETTINGS_REINDEX=true | |||
| - ELASTICSEARCH_BUILD_INDICES_CLONE_INDICES=false | |||
| - GRAPH_SERVICE_IMPL=elasticsearch | |||
| - GRAPH_SERVICE_IMPL=neo4j | |||
There was a problem hiding this comment.
Same here, please make it configurable: GRAPH_SERVICE_IMPL=${GRAPH_SERVICE_IMPL:-elasticsearch}
|
Thanks! If we can restore the default and allow overriding of the graph impl, then this looks good to me! |
… "python generate_docker_quickstart.py check-all"
|
@david-leifker |
# Conflicts: # docker/quickstart/docker-compose-m1.quickstart.yml # docker/quickstart/docker-compose.quickstart.yml
|
LGTM! Thanks! |
By default datahub connects to default db when neo4j is being used for Graph service implementation. With this PR, we can provide specific database in neo4j to connect to.
Also, changes default value of graph_service_impl in docker quickstart files
Checklist