feat(ui): Add command-k icons to search bar #9194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
cool beans definitely love the command K situation. idk if we want to always show it in the search bar - I don't have too strong of an opinion and could be convinced - but maybe we don't want to busy up the search bar everywhere for an optional delight feature?
one option that notion does is shows the shortcut on hover. maybe that's an option?
| @@ -411,6 +421,7 @@ export const SearchBar = ({ | |||
| </> | |||
| } | |||
| ref={searchInputRef} | |||
| suffix={(showCommandK && !isFocused && <CommandK />) || null} | |||
There was a problem hiding this comment.
do you think we need this command k icon? tbh it feels a little busy and maybe not necessary to show for this. we could show something as a tooltip when you hover over the search bar that it's possible to do command K?
Comment on lines
+304
to
+318
| if (showCommandK) { | ||
| const handleKeyDown = (event) => { | ||
| // Support command-k to select the search bar. | ||
| // 75 is the keyCode for 'k' | ||
| if ((event.metaKey || event.ctrlKey) && event.keyCode === 75) { | ||
| (searchInputRef?.current as any)?.focus(); | ||
| } | ||
| }; | ||
| document.addEventListener('keydown', handleKeyDown); | ||
| return () => { | ||
| document.removeEventListener('keydown', handleKeyDown); | ||
| }; | ||
| } | ||
| return () => null; | ||
| }, [showCommandK]); |
There was a problem hiding this comment.
oh nice so we already supported this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, you could auto-select search using command k but this feature was hidden. In this PR we add iconography to search bar to display that you can select the bar using command k.
We also fix a minor issue where on some search bars command k was showing when it should not have.
Checklist