Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/redshift): patch instead of replace redshift custom properties #9293

Merged
merged 42 commits into from
Mar 11, 2024
Merged

fix(ingest/redshift): patch instead of replace redshift custom properties #9293

merged 42 commits into from
Mar 11, 2024

Conversation

ethan-cartwright
Copy link
Contributor

@ethan-cartwright ethan-cartwright commented Nov 22, 2023 •
edited
Loading

Testing

  • added tests
  • tested this locally to ensure it works for:
    • custom properties
    • that table descriptions and other set methods function as expected
    • the patch_custom_properties flag works as expected

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 22, 2023
@ethan-cartwright ethan-cartwright changed the title Patch instead of replace redshift custom properties fix:patch instead of replace redshift custom properties Nov 22, 2023
@ethan-cartwright ethan-cartwright changed the title fix:patch instead of replace redshift custom properties fix: patch instead of replace redshift custom properties Nov 22, 2023
@ethan-cartwright ethan-cartwright changed the title fix: patch instead of replace redshift custom properties fix(ingest/redshift): patch instead of replace redshift custom properties Nov 22, 2023
asikowitz
asikowitz reviewed Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@asikowitz asikowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a quick glance, seems like we're no longer setting some properties we should be setting

metadata-ingestion/src/datahub/ingestion/source/redshift/redshift.py Outdated Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/redshift/redshift.py Outdated Show resolved Hide resolved
@ethan-cartwright ethan-cartwright requested a review from hsheth2 March 4, 2024 01:16
hsheth2
hsheth2 approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once the two small tweaks are made, and assuming the patch changes have been tested against a live datahub system

metadata-ingestion/src/datahub/ingestion/source/redshift/redshift.py Outdated
)
else:
if custom_properties:
dataset_properties.customProperties = custom_properties
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is redundant, since we set it above

metadata-ingestion/tests/unit/test_redshift_source.py Outdated
from datahub.ingestion.source.redshift.redshift_schema import RedshiftTable


@pytest.fixture
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this probably should be a helper method instead of a fixture

@hsheth2 hsheth2 merged commit 7540e64 into datahub-project:master Mar 11, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asikowitz asikowitz asikowitz left review comments

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ethan-cartwright @asikowitz @hsheth2 @anshbansal