feat(ingest): add ingest --no-progress option
#9300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ingestion
hsheth2
reviewed
Nov 28, 2023
There was a problem hiding this comment.
I agree with the overall premise here - those messages can be annoyingly chatty at times
My main worry is the flag's naming. In most CLIs, --quiet suppresses all log messages and is effectively the inverse of --verbose.
Can we rename quiet to --no-progress or --no-print-progress to more accurately reflect what it does?
|
Hello, @hsheth2, thanks for your comment :) I agree that your worry about expression |
hsheth2
changed the title
--no-progress option
hsheth2
added
the
merge-pending-ci
|
Thank you for taking care of this PR, @hsheth2. Please, schedule the PR can be merged 🙏 |
Salman-Apptware
pushed a commit
to Salman-Apptware/datahub
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Hello, guys. I want to silent intermediate ingestion report.
When, I ingest data from Databricks or Redshift platform, it takes more than 30 minutes, and it generates large log files (ex. 11 Mb). I want to avoid this situation, as it slows down our logging platform.
I added
--quiet,-qoption on ingest-cli, before the--dry-run, but please let me know that it's order should be changed.