fix(ingest/s3): Not sorting schema fields to keep original order #9349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding way to enable ** in path_spec include
github-actions
bot
added
the
ingestion
hsheth2
reviewed
Nov 30, 2023
| @@ -63,6 +63,11 @@ class Config: | |||
| description="Not listing all the files but only taking a handful amount of sample file to infer the schema. File count and file size calculation will be disabled. This can affect performance significantly if enabled", | |||
| ) | |||
|
|
|||
| allow_double_stars: bool = Field( | |||
There was a problem hiding this comment.
is double star supported on all sources that use path spec? do we have tests on the data lake source that test the ** behavior for includes?
I know it always works in the exclude paths, but not include iirc
There was a problem hiding this comment.
Double star is a valid glob pattern and whichever source support glob, it should support double star as well.
hsheth2
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sorting schema fields to keep original order
Adding way to enable ** in path_spec include
Checklist