feat: allow the sidebar size to be draggable #9401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjoyce0510
reviewed
Dec 11, 2023
| <div className="entity" {...provided.droppableProps} ref={provided.innerRef}> | ||
| {updateEntityAggregations?.map((entityAggregation, index)=> { | ||
| return ( | ||
| <Draggable key={entityAggregation.value} draggableId={entityAggregation.value} index={index}> |
There was a problem hiding this comment.
Why do we need all of the draggable stuff here?
Can we just follow the same pattern we are using on the other sidebar? This will require new developers get up to speed on this draggable thing
I might be missing some advantage to introducing this, though. If yes, can you please explain?
There was a problem hiding this comment.
I was confused between draggable and resizer as ticket having title "allow the sidebar size to be draggable" after I post video on linear @Aseem Bansal said we need Resizer. you can also check conversation on ticket
There was a problem hiding this comment.
I have remove Draggable
Resizer.webm |
anshbansal
approved these changes
Dec 12, 2023
Salman-Apptware
added a commit
to Salman-Apptware/datahub
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist