Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(patch): support fine grained lineage patches #9408

Merged
merged 13 commits into from
Dec 11, 2023
Merged

feat(patch): support fine grained lineage patches #9408

merged 13 commits into from
Dec 11, 2023

Conversation

RyanHolstien
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@RyanHolstien RyanHolstien added ingestion PR or Issue related to the ingestion of metadata devops PR or Issue related to DataHub backend & deployment labels Dec 7, 2023
@RyanHolstien RyanHolstien self-assigned this Dec 7, 2023
@github-actions github-actions bot removed the devops PR or Issue related to DataHub backend & deployment label Dec 7, 2023
hsheth2
hsheth2 reviewed Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the python code mostly looks good, just a few style/testing things

metadata-ingestion/src/datahub/specific/dataset.py Outdated Show resolved Hide resolved
metadata-ingestion/src/datahub/specific/dataset.py Outdated Show resolved Hide resolved
metadata-ingestion/src/datahub/specific/dataset.py Show resolved Hide resolved
metadata-ingestion/src/datahub/specific/dataset.py Show resolved Hide resolved
@RyanHolstien RyanHolstien merged commit 8a11220 into datahub-project:master Dec 11, 2023
56 checks passed
@RyanHolstien RyanHolstien deleted the feat/fineGrainedLineagePatch branch December 11, 2023 22:25
Salman-Apptware pushed a commit to Salman-Apptware/datahub that referenced this pull request Dec 15, 2023
@RyanHolstien @hsheth2 @Salman-Apptware
feat(patch): support fine grained lineage patches (datahub-project#9408)
4ae175f 
Co-authored-by: Harshal Sheth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 left review comments

@david-leifker david-leifker david-leifker approved these changes

Assignees

@RyanHolstien RyanHolstien

Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RyanHolstien @hsheth2 @david-leifker