Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): gradle 8, jdk17, neo4j 5 #9458

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Conversation

david-leifker
Copy link
Collaborator

@david-leifker david-leifker commented Dec 13, 2023

Major Build Change

Upgrade to jdk17, gradle 8, neo4j 5. Deprecates Spark 2.x and jdk8 requirements.

Includes some pegasus gradle plugin hacks in buildSrc to support gradle 8

Build Times:

# System: Linux
# CPU: AMD Ryzen 7 5800X 8-Core Processor
# Memory: 32GB

./gradlew clean test --rerun-tasks
...
BUILD SUCCESSFUL in 9m 14s
464 actionable tasks: 464 executed
# System: Sonoma 14.1
# CPU: Apple M1 Max
# Memory: 32GB

./gradlew clean test --rerun-tasks
...
BUILD SUCCESSFUL in 12m
464 actionable tasks: 464 executed
# System:
# CPU: Apple M2 Max
# Memory: 32GB

./gradlew clean test --rerun-tasks
...
BUILD SUCCESSFUL in 10m 5s
464 actionable tasks: 464 executed

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata docs Issues and Improvements to docs product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment smoke_test Contains changes related to smoke tests labels Dec 13, 2023
build.gradle Outdated Show resolved Hide resolved
@david-leifker david-leifker merged commit 824df5a into master Dec 15, 2023
59 checks passed
@david-leifker david-leifker deleted the jdk-build-updates branch December 15, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment docs Issues and Improvements to docs ingestion PR or Issue related to the ingestion of metadata product PR or Issue related to the DataHub UI/UX release-0.13.0 smoke_test Contains changes related to smoke tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants