Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix | PRD-463 | Stop trying to ping the track endpoint on login home … #9462

Merged
merged 1 commit into from
Dec 14, 2023
Merged

fix | PRD-463 | Stop trying to ping the track endpoint on login home … #9462

merged 1 commit into from
Dec 14, 2023

Conversation

sumitappt
Copy link
Contributor

…page before login

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Dec 14, 2023
@sumitappt
Copy link
Contributor Author

Here is the working video of it
Screencast from 14-12-23 05:47:24 PM IST.webm

@anshbansal anshbansal added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Dec 14, 2023
@anshbansal anshbansal merged commit 9ecda64 into datahub-project:master Dec 14, 2023
38 checks passed
Salman-Apptware pushed a commit to Salman-Apptware/datahub that referenced this pull request Dec 15, 2023
@sumitappt @Salman-Apptware
fix(analytics): do not ping the track endpoint before login (datahub-…
b34a3ec 
…project#9462)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anshbansal anshbansal anshbansal approved these changes

Assignees
No one assigned
Labels
merge-pending-ci A PR that has passed review and should be merged once CI is green. product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sumitappt @anshbansal