Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest/openapi): support proxies and alternate auth schemes #9492

Merged
merged 6 commits into from
Dec 28, 2023
Merged

feat(ingest/openapi): support proxies and alternate auth schemes #9492

merged 6 commits into from
Dec 28, 2023

Conversation

fer-marino
Copy link
Contributor

@fer-marino fer-marino commented Dec 20, 2023 •
edited by hsheth2
Loading

fixes #7914
adding http proxies
support for authentication scheme other than bearer

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

fix for datahub-project#7914
29e8089 
adding http proxies
support for authentication scheme other than bearer
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Dec 20, 2023
hsheth2
hsheth2 reviewed Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly looks good, just a few tweaks needed

metadata-ingestion/src/datahub/ingestion/source/openapi_parser.py Outdated Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/openapi.py Outdated Show resolved Hide resolved
@hsheth2 hsheth2 changed the title fix for https://github.com/datahub-project/datahub/issues/7914 feat(ingest/openapi): support proxies and alternate auth schemes Dec 20, 2023
@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Dec 21, 2023
@hsheth2 hsheth2 merged commit b7a0bbc into datahub-project:master Dec 28, 2023
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ingestion through OpenAPI as a source: get_token's request_type as a POST is not working
2 participants
@fer-marino @hsheth2