fix(frontend): Add fallback for image load error on Avatar #9501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const avatar = | ||
| photoUrl && photoUrl !== '' ? <AvatarStyled src={photoUrl} style={style} size={size} /> : avatarWithDefault; | ||
| photoUrl && photoUrl !== '' && !imageError ? <AvatarStyled src={photoUrl} style={style} size={size} onError={() => onErrorHandling()} /> : avatarWithDefault; |
There was a problem hiding this comment.
it's unnecessary to have an arrow function here, you could just write onError={onErrorHandling}
I would also rename this from onErrorHandling to something like handleImageError to be a little more clear, verbose, and consistent with our function names
added 2 commits
January 9, 2024 08:48
…hub.com/ingthorb/datahub into add_backup_photo_for_avatar_picture_url
hsheth2
added
the
merge-pending-ci
chriscollins3456
merged commit 0b66e5e
into
datahub-project:master
35 of 36 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a fix for when using the CorpUser Image URL and there is an error when fetching the image. Before the error was not handled and showed an empty space where the image should be but now with the onError function from Ant we have a fallback Avatar Style which is the default one.
Checklist