fix(ingestion/mssql): use platform_instance for mssql dataflow/datajob #9527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name of df&dj; add platform_instance to make_data_flow(job)_urn method; remove dot replacing in formatted_platform_instance methods
github-actions
bot
added
the
ingestion
hsheth2
reviewed
Jan 3, 2024
| @@ -72,15 +72,15 @@ class MSSQLProceduresContainer: | |||
|
|
|||
| @property | |||
| def formatted_name(self) -> str: | |||
| return f"{self.formatted_platform_instance}.{self.name.replace(',', '-')}" | |||
| return self.name.replace(',', '-') | |||
|
|
|||
| @property | |||
| def orchestrator(self) -> str: | |||
| return self.source | |||
|
|
|||
| @property | |||
| def formatted_platform_instance(self) -> str: | |||
There was a problem hiding this comment.
can we get rid of this altogether? e.g. just use .platform_instance everywhere
|
|
||
| @property | ||
| def orchestrator(self) -> str: | ||
| return self.source | ||
|
|
||
| @property | ||
| def formatted_platform_instance(self) -> str: | ||
| return self.platform_instance.replace(".", "/") | ||
| return self.platform_instance |
There was a problem hiding this comment.
looking at this in more detail, it seems like platform_instance really should be of type Optional[str] and not str as declared here
…ance method; declare platform_instance property as optional
…eep/datahub into feature/fix_mssql_df_dj
|
Hi @hsheth2! Fixed. |
hsheth2
approved these changes
Jan 8, 2024
hsheth2
added
the
merge-pending-ci
…ance method; declare platform_instance property as optional; update golden files
hsheth2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove platform_instance from name of df&dj;
add platform_instance to make_data_flow(job)_urn method;
remove dot replacing in formatted_platform_instance methods.