openapi-v3 #9550
openapi-v3 #9550
Conversation
david-leifker
force-pushed
the
feature/data-platform-1
branch
from
eb5f97f to
58b3d87
Compare
david-leifker
force-pushed
the
feature/data-platform-1
branch
4 times, most recently
from
6c65357 to
f061124
Compare
david-leifker
force-pushed
the
feature/data-platform-1
branch
from
f061124 to
dc16ed8
Compare
david-leifker
force-pushed
the
feature/data-platform-1
branch
2 times, most recently
from
7ac1b22 to
be9d7b0
Compare
| @@ -92,6 +92,10 @@ public MergedEntityRegistry apply(EntityRegistry patchEntityRegistry) | |||
| } | |||
| } | |||
|
|
|||
| if (!patchEntityRegistry.getAspectSpecs().isEmpty()) { | |||
There was a problem hiding this comment.
This appears to be duplicated from above, if this needs to run after the merge entity specs block then first one should be removed.
| assertEquals(openAPI.getComponents().getSchemas().size(), 914); | ||
| assertEquals(openAPI.getComponents().getParameters().size(), 56); | ||
| assertEquals(openAPI.getPaths().size(), 102); | ||
| assertTrue(openAPI.getComponents().getSchemas().size() >= 882); |
There was a problem hiding this comment.
This seems like an odd spot to have varying numbers, I think we'd want to know if new schemas are showing up? Maybe it's not important though if this will change often.
There was a problem hiding this comment.
They would change on every data model update including changes to the entity-registry. The numbers are going to increase fairly constantly unless we start deprecating things. A simple non-zero check would however not be as useful since it might actually be broken for large chunks of the data models so this is trying to detect a regression rather then ensuring perfect accuracy.
Co-authored-by: david-leifker <[email protected]>
* json schema validator update * tests fixes, timeline, counts
review comment addressed
david-leifker
force-pushed
the
feature/data-platform-1
branch
from
be9d7b0 to
be55eea
Compare
| @@ -18,7 +18,8 @@ | |||
| "io.datahubproject.openapi.v1", | |||
| "io.datahubproject.openapi.v2", | |||
| "io.datahubproject.openapi.v3", | |||
| "com.linkedin.gms.factory.timeline" | |||
| "com.linkedin.gms.factory.timeline", | |||
| "org.springdoc" | |||
There was a problem hiding this comment.
Curious, why was this necessary?
There was a problem hiding this comment.
The org.springdoc package includes the @Controller classes that create the swagger UI endpoints. Without Spring able to detect those controllers they never get wired up.
| NONDEFAULT_OPENAPI_PACKAGES.addAll(V1_PACKAGES); | ||
| NONDEFAULT_OPENAPI_PACKAGES.addAll(V2_PACKAGES); | ||
| NONDEFAULT_OPENAPI_PACKAGES.addAll(V3_PACKAGES); | ||
| } |
There was a problem hiding this comment.
the new default openapi page will now have all of the above packages right? AKA we don't want to hide them anymore
There was a problem hiding this comment.
The difference is there is actually no longer a catch-all group. If new endpoints are added they must either fall into an existing group or a new group can be added. This is more explicit and avoids wiring up endpoints inadvertently with some misplaced annotations.
|
The python tests are failing for some reason, will be resolved with #10318 |
Co-authored-by: Ajoy Majumdar <[email protected]> Adds support for custom aspects in the openapi api
Checklist