fix(owner): last modified on adding owner

[anshbansal]

• Fix last modified not being updated on adding owner via the UI
• Some cleanup in OwnerUtils to avoid copy-paste
• Rename some confusing variable names
• Optional should not be an argument to methods
• Extract code out to make code readable in OwnerUtils

Things to pay special attention to

• With the ownership type how do we define equality of an Owner? If owner urn is same but ownership type is different then is owner obj considered equal? There were 2 different definitions of equality in add owner and remove owner in OwnerUtils here. I have updated it to be what I consider to be correct equality definition. But please pay attention to that.

Checklist

• The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
• Links to related issues (if applicable)
• Tests for the changes have been added/updated (if applicable)
• Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
• For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

[chriscollins3456]

looking solid! left one question about whether some logic is correct and then a suggestion for some tests

[pedro93]

We are missing 1 test here I think:

assertTrue(OwnerUtils.isOwnerEqual(ownerWithoutOwnershipType, ownerUrn1, technicalOwnershipTypeUrn));

An owner without ownership type should be equal to the same owner being assigned a concrete ownership type so that all owners have a type of ownership assigned.

[pedro93]

Actually I don't think this case is possible since the deprecated type is mandatory in our pdl definition.

However we can have:

Owner ownerWithoutOwnershipType = new Owner();
ownerWithoutOwnershipType.setOwner(ownerUrn1);
ownerWithoutOwnershipType.setType(NONE);

assertTrue(OwnerUtils.isOwnerEqual(ownerWithoutOwnershipType, ownerUrn1, technicalOwnershipTypeUrn));

[pedro93]

LGTM, wait for green CI.