-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ingest/glue): Profiling breaks for non-partitioned tables due to absent Table.PartitionKeys
#9591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KulykDmytro
changed the title
(ingest/glue)
fix (ingest/glue) Jan 9, 2024
Table.PartitionKeys
can be absent for non-partitioned tablesTable.PartitionKeys
can be absent for non-partitioned tables
KulykDmytro
changed the title
fix (ingest/glue)
fix(ingest/glue) Jan 9, 2024
Table.PartitionKeys
can be absent for non-partitioned tablesTable.PartitionKeys
can be absent for non-partitioned tables
KulykDmytro
changed the title
fix(ingest/glue)
fix(ingest/glue) Profiling breaks for non-partitioned tables due to absent Jan 12, 2024
Table.PartitionKeys
can be absent for non-partitioned tablesTable.PartitionKeys
hsheth2
reviewed
Jan 18, 2024
# check if this table is partitioned | ||
if partition_keys: | ||
if partition_keys := response["Table"].get("PartitionKeys"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can't use the :=
walrus operator since we need to maintain compatibility with python 3.7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it will change
hsheth2
approved these changes
Jan 25, 2024
hsheth2
added
community-contribution
PR or Issue raised by member(s) of DataHub Community
merge-pending-ci
A PR that has passed review and should be merged once CI is green.
labels
Jan 25, 2024
hsheth2
changed the title
fix(ingest/glue) Profiling breaks for non-partitioned tables due to absent
fix(ingest/glue): Profiling breaks for non-partitioned tables due to absent Jan 26, 2024
Table.PartitionKeys
Table.PartitionKeys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community-contribution
PR or Issue raised by member(s) of DataHub Community
merge-pending-ci
A PR that has passed review and should be merged once CI is green.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
While profiling glue table can face with issue:
this caused due to response for non-partitioned tables do not contain
Table.PartitionKeys
keyChecklist