Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingest/looker): add backpressure-aware executor #9615

Merged
merged 5 commits into from
Jan 12, 2024

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Jan 11, 2024

In some cases, the source can produce metadata faster than the sink can consume it. In most cases, our pipeline orchestration pauses the source's execution until the sink is less overwhelmed. This PR extends that throttling capability into the ThreadPoolExecutor.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jan 11, 2024
@hsheth2 hsheth2 force-pushed the looker-pressure-exec branch from 0b73aef to 1ad01b5 Compare January 11, 2024 21:44
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@treff7es
Copy link
Contributor

@hsheth2 it seems like integration tests are failing

@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Jan 12, 2024
@treff7es treff7es merged commit 98e3da4 into master Jan 12, 2024
48 of 50 checks passed
@treff7es treff7es deleted the looker-pressure-exec branch January 12, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants