Added Homepage Post Steps #9620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
smoke_test
anshbansal
requested changes
Jan 12, 2024
| cy.get('[data-testid="create-post-button"]').click({ force: true }); | ||
| cy.reload() | ||
| homePageRedirection(); | ||
| cy.waitTextPresent(announcementTitle); |
There was a problem hiding this comment.
Why is this global variable being used instead of the argument?
There was a problem hiding this comment.
We've utilized it several times in the test, so we've stored it in a variable for easy access and called it as needed., if you wan't we can remove the variable and use direct title argument
| cy.waitTextPresent(announcementTitle); | ||
| } | ||
|
|
||
| const addLink = (linkTitle, linkURL, imageURL) => { |
There was a problem hiding this comment.
Please don't keep same name as global variable. Can cause confusion on what is being used.
There was a problem hiding this comment.
okay will change it, thanks!
anshbansal
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist