fix(ingestion/metabase): Fetch Dashboards through Collections #9631
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -57,7 +57,8 @@ | |
| }, | ||
| "systemMetadata": { | ||
| "lastObserved": 1636614000000, | ||
| "runId": "metabase-test", | ||
| "lastRunId": "no-run-id-provided" | ||
| } | ||
| }, | ||
| { | ||
|
|
@@ -112,7 +113,8 @@ | |
| }, | ||
| "systemMetadata": { | ||
| "lastObserved": 1636614000000, | ||
| "runId": "metabase-test", | ||
| "lastRunId": "no-run-id-provided" | ||
| } | ||
| }, | ||
| { | ||
|
|
@@ -167,7 +169,8 @@ | |
| }, | ||
| "systemMetadata": { | ||
| "lastObserved": 1636614000000, | ||
| "runId": "metabase-test", | ||
| "lastRunId": "no-run-id-provided" | ||
| } | ||
| }, | ||
| { | ||
|
|
@@ -180,10 +183,55 @@ | |
| "customProperties": {}, | ||
| "title": "Dashboard 1", | ||
| "description": "", | ||
| "charts": [], | ||
| "datasets": [], | ||
| "lastModified": { | ||
| "created": { | ||
| "time": 1639417721742, | ||
| "actor": "urn:li:corpuser:[email protected]" | ||
| }, | ||
| "lastModified": { | ||
| "time": 1639417721742, | ||
| "actor": "urn:li:corpuser:[email protected]" | ||
| } | ||
| }, | ||
| "dashboardUrl": "http://localhost:3000/dashboard/10" | ||
| } | ||
| }, | ||
| { | ||
| "com.linkedin.pegasus2avro.common.Ownership": { | ||
| "owners": [ | ||
| { | ||
| "owner": "urn:li:corpuser:[email protected]", | ||
| "type": "DATAOWNER" | ||
| } | ||
| ], | ||
| "lastModified": { | ||
| "time": 0, | ||
| "actor": "urn:li:corpuser:unknown" | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| "systemMetadata": { | ||
| "lastObserved": 1636614000000, | ||
| "runId": "metabase-test", | ||
| "lastRunId": "no-run-id-provided" | ||
| } | ||
| }, | ||
| { | ||
| "proposedSnapshot": { | ||
| "com.linkedin.pegasus2avro.metadata.snapshot.DashboardSnapshot": { | ||
| "urn": "urn:li:dashboard:(metabase,1)", | ||
| "aspects": [ | ||
| { | ||
| "com.linkedin.pegasus2avro.dashboard.DashboardInfo": { | ||
| "customProperties": {}, | ||
| "title": "Dashboard 1", | ||
| "description": "", | ||
| "charts": [], | ||
| "datasets": [], | ||
| "lastModified": { | ||
| "created": { | ||
|
|
@@ -195,7 +243,7 @@ | |
| "actor": "urn:li:corpuser:[email protected]" | ||
| } | ||
| }, | ||
| "dashboardUrl": "http://localhost:3000/dashboard/10" | ||
| } | ||
| }, | ||
| { | ||
|
|
@@ -217,7 +265,8 @@ | |
| }, | ||
| "systemMetadata": { | ||
| "lastObserved": 1636614000000, | ||
| "runId": "metabase-test", | ||
| "lastRunId": "no-run-id-provided" | ||
| } | ||
| }, | ||
| { | ||
|
|
@@ -232,7 +281,8 @@ | |
| }, | ||
| "systemMetadata": { | ||
| "lastObserved": 1636614000000, | ||
| "runId": "metabase-test", | ||
| "lastRunId": "no-run-id-provided" | ||
| } | ||
| }, | ||
| { | ||
|
|
@@ -247,7 +297,8 @@ | |
| }, | ||
| "systemMetadata": { | ||
| "lastObserved": 1636614000000, | ||
| "runId": "metabase-test", | ||
| "lastRunId": "no-run-id-provided" | ||
| } | ||
| }, | ||
| { | ||
|
|
@@ -262,7 +313,8 @@ | |
| }, | ||
| "systemMetadata": { | ||
| "lastObserved": 1636614000000, | ||
| "runId": "metabase-test", | ||
| "lastRunId": "no-run-id-provided" | ||
| } | ||
| }, | ||
| { | ||
|
|
@@ -277,7 +329,8 @@ | |
| }, | ||
| "systemMetadata": { | ||
| "lastObserved": 1636614000000, | ||
| "runId": "metabase-test", | ||
| "lastRunId": "no-run-id-provided" | ||
| } | ||
| } | ||
| ] | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| {"total": 1, "data": [{"description": null, "collection_position": null, "database_id": null, "name": "This is a test", "id": 10, "entity_id": "Q4gEaOmoBkfQX3_gXiH9g", "last-edit-info": {"id": 14, "last_name": "Doe", "first_name": "John", "email": "[email protected]", "timestamp": "2024-01-12T14:55:38.43304Z"}, "model": "dashboard"}], "models": ["dashboard"], "limit": null, "offset": null} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| [{"authority_level": null, "can_write": true, "name": "Our analytics", "effective_ancestors": [], "effective_location": null, "parent_id": null, "id": "root", "is_personal": false}, {"authority_level": null, "description": null, "archived": false, "slug": "john_doe_personal_collection", "can_write": true, "name": "John Doe", "personal_owner_id": 14, "type": null, "id": 150, "entity_id": "kdLA_-CQy4F5lL15k8-TU", "location": "/", "namespace": null, "is_personal": true, "created_at": "2024-01-12T11:51:24.394309Z"}] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -330,4 +330,4 @@ | |
| "created_at": "2021-12-13T17:46:48.185", | ||
| "public_uuid": null, | ||
| "points_of_interest": null | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,8 +14,10 @@ | |
| JSON_RESPONSE_MAP = { | ||
| "http://localhost:3000/api/session": "session.json", | ||
| "http://localhost:3000/api/user/current": "user.json", | ||
|
There was a problem hiding this comment. can we delete the There was a problem hiding this comment. I struggled to run these tests, actually. I did set my machine to java 8 but couldn't run the gradlew successfully. There was a problem hiding this comment. @hsheth2 I'm using my GH Actions to test it https://github.com/7onn/datahub/actions There was a problem hiding this comment. We've actually migrated to java 17 now Have you taken a look at these docs https://datahubproject.io/docs/next/metadata-ingestion/developing/ Let me know if you run into issues with it - we want developing on ingestion, including tests, to be a smooth experience |
||
| "http://localhost:3000/api/collection/": "collections.json", | ||
| "http://localhost:3000/api/collection/root/items?models=dashboard": "collection_dashboards.json", | ||
| "http://localhost:3000/api/collection/150/items?models=dashboard": "collection_dashboards.json", | ||
| "http://localhost:3000/api/dashboard/10": "dashboard_1.json", | ||
| "http://localhost:3000/api/user/1": "user.json", | ||
| "http://localhost:3000/api/card": "card.json", | ||
| "http://localhost:3000/api/database/1": "bigquery_database.json", | ||
|
|
@@ -26,7 +28,7 @@ | |
| "http://localhost:3000/api/card/3": "card_3.json", | ||
| } | ||
|
|
||
| RESPONSE_ERROR_LIST = ["http://localhost:3000/api/dashboard/public"] | ||
|
|
||
| test_resources_dir = pathlib.Path(__file__).parent | ||
|
|
||
|
|
@@ -114,9 +116,9 @@ def test_mode_ingest_success(pytestconfig, tmp_path): | |
| }, | ||
| } | ||
| ) | ||
|
|
||
| pipeline.run() | ||
| pipeline.raise_from_status() | ||
| mce_helpers.check_golden_file( | ||
| pytestconfig, | ||
| output_path=f"{tmp_path}/metabase_mces.json", | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like the relationships between dashboards and charts disappeared? Given that it's an important part of the integration, can we update the code / test data to make sure we're testing the dashboard -> chart relationship generation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed by: