Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(graphql): generate ToString method #9634

Merged
merged 1 commit into from
Jan 16, 2024
Merged

feat(graphql): generate ToString method #9634

merged 1 commit into from
Jan 16, 2024

Conversation

anshbansal
Copy link
Collaborator

Required to improve application logging which is required to debug issues

Validated locally generated code.
image

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@anshbansal anshbansal requested a review from pedro93 January 16, 2024 10:27
@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Jan 16, 2024
pedro93
pedro93 approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@pedro93 pedro93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for green CI

@anshbansal anshbansal merged commit 261fcb0 into master Jan 16, 2024
37 checks passed
@anshbansal anshbansal deleted the ab-tweak-codegen-options branch January 16, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedro93 pedro93 pedro93 approved these changes

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshbansal @pedro93