Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(forms) Add support for metadata forms on entities in the UI #9718

Merged

Conversation

chriscollins3456
Copy link
Collaborator

This PR adds support for the forms feature in the UI - the backend piece was already merged in this PR: #9626

Here, we build out all of the frontend components to check to see if an entity has any forms (supports more than 1 form). If so, we display a new section in the sidebar of an entity's profile page. If you are assigned to fill out this form, then we will show you a CTA to respond to the form if need be, or shows you information about the documentation or verification status.

The CTA will open a full page modal allowing you to edit or view the form for that entity. If there is more than one form on an entity you can select which one you want to view. Editing the form will automatically update the entity and add the metadata you fill out.

Right now the only metadata we support on forms is structured properties. Soon we will be expanding this to include support for owners, domains, tags etc.

Note: right now this is only supported for datasets, but we are planning on expanding forms and structured properties to all entities with profile pages as a followup

Screenshots:

image image image image image

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Jan 25, 2024
@chriscollins3456 chriscollins3456 merged commit 8151769 into datahub-project:master Feb 2, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants