fix(search): fix filters for hasX and numValues fields #9729
Conversation
RyanHolstien
added
the
platform
| fieldSet.add(numValuesField); | ||
| fieldSpecMap.put(fieldName, fieldSet); | ||
| } | ||
| if (searchableAnnotation.getHasValuesFieldName().isPresent()) { |
There was a problem hiding this comment.
@jjoyce0510 and I talked about this method being undesirable since it is creating a mostly empty annotation and an annotation that doesn't really reflect the expectations of the boolean field.
The thought was to create/generate a field map with a simpler value than a full scale annotation object.
There was a problem hiding this comment.
Sure, it really only needs a couple of the fields so that makes sense.
There was a problem hiding this comment.
SearchableAnnotation should directly model the annotation inside the PDL files. That is the charter for that object..
If we need another intermediary abstraction to represent the Actual physical index fields that get minted as a result of a SearchableAnnotation, we should create it. Something like SearchableField or something. It can store a pointer to the origin SearchableAnnotation if required.
There was a problem hiding this comment.
That's what SearchableFieldSpec already is, we just directly access the annotation object for all the information we use instead of duplicating it.
Checklist