feat(platform): add support for via nodes #9733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ingestion
shirshanka
force-pushed
the
feat-via-nodes
branch
from
1c5a94b to
e7be03b
Compare
jjoyce0510
reviewed
Jan 29, 2024
| * The type of the entity to be grouped. | ||
| * e.g. schemaField | ||
| */ | ||
| rawEntityType: string |
There was a problem hiding this comment.
one optimization on model:
make this optional, which means "applies to all entity types"
jjoyce0510
reviewed
Jan 29, 2024
| A grouping specification for search results | ||
| """ | ||
| input GroupingSpec { | ||
|
|
There was a problem hiding this comment.
nit: Can we copy the PDL comment here
jjoyce0510
reviewed
Jan 29, 2024
| @@ -143,6 +143,11 @@ input SearchFlags { | |||
| Whether to request for search suggestions on the _entityName virtualized field | |||
| """ | |||
| getSuggestions: Boolean | |||
|
|
|||
| """ | |||
| Additional grouping specifications to apply to the search results | |||
There was a problem hiding this comment.
Lets add maybe note:
Notice: This API is experimental and subject to change.
jjoyce0510
reviewed
Jan 29, 2024
| """ | ||
| The raw entity type that needs to be grouped | ||
| """ | ||
| rawEntityType: String! |
There was a problem hiding this comment.
EntityType -> GraphQL entity type enum
here is an example:
Conversion:
also, maybe we can call this baseEntityType
jjoyce0510
reviewed
Jan 29, 2024
| @@ -45,7 +45,8 @@ public void testDefaultSearchFlags() throws Exception { | |||
| .setSkipAggregates(false) | |||
| .setSkipHighlighting(true) // empty/wildcard | |||
| .setMaxAggValues(20) | |||
| .setSkipCache(false)); | |||
| .setSkipCache(false) | |||
| .setConvertSchemaFieldsToDatasets(true)); | |||
There was a problem hiding this comment.
Is this flag intentional
jjoyce0510
reviewed
Jan 29, 2024
| @@ -7,16 +7,23 @@ | |||
|
|
|||
| @Slf4j | |||
| public class GraphRelationshipMappingsBuilder { | |||
| public static final String EDGE_FIELD_SOURCE = "source"; | |||
| public static final String EDGE_FIELD_DESTINATION = "destination"; | |||
jjoyce0510
reviewed
Jan 29, 2024
| final InputFields inputFields = new InputFields(aspect.data()); | ||
| updateInputFieldEdgesAndRelationships( | ||
| urn, inputFields, edgesToAdd, urnToRelationshipTypesBeingAdded); | ||
| } else if (aspectSpec.getName().equals(Constants.DATA_JOB_INPUT_OUTPUT_ASPECT_NAME)) { |
There was a problem hiding this comment.
special cases... we'll need to come back on all of these
jjoyce0510
reviewed
Jan 29, 2024
jjoyce0510
reviewed
Jan 29, 2024
metadata-io/src/main/java/com/linkedin/metadata/search/LineageSearchService.java
Show resolved
Hide resolved
jjoyce0510
approved these changes
Jan 29, 2024
david-leifker
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are 'Via Nodes'
Via nodesare entities designed to represent relationships between two distinct entities in the graph model. They typically represent processes like queries or data jobs that generate column-level lineage between fields, enhancing the model's capabilities in lineage representation. Via nodes are convenient performance and metadata representation shortcuts in cases where paths between two entities transit through a common node that is an intersection point for other paths.e.g. consider fine-grained lineage produced by a job J that looks like
T1 col c11, c12 --> (job J) --> T2 col c21, c22and
T1 col c13, c14 --> (job J) --> T2 col 23via nodes allow us to concisely represent and query these paths, without needing to create edge specific nodes (e.g. in this case, we do NOT need to mint fake ColumnProcess nodes J-1 , and J-2 to keep the paths separated unlike other metadata systems like Apache Atlas)
Caveat emptor:
vianodes are experimental - and we'll revisit this decision in case this optimization doesn't yield as many benefits as we think it will.Summary
This pull request implements 'via nodes' within the graph model and updates the annotation language for compatibility, aiming to improve the model's data representation and querying capabilities.
Model Changes
Implementation Changes in GMS
Testing
Checklist