Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forms) Update styles of submit/confirm button and fix num input bug #9797

Conversation

chriscollins3456
Copy link
Collaborator

This PR introduces new styles for the submit button to have it be below the inputs and also introduces a "confirm" button when a prompt's metadata is already there but they haven't submitted it through the form. This is the bulk of the diff (specifically indenting a component).

This also fixes a bug where we wouldn't show the number zero in number inputs.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Feb 7, 2024
@chriscollins3456 chriscollins3456 merged commit 33dc96b into datahub-project:master Feb 8, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants