Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(forms) Extend forms support to other entity types #9801

Conversation

chriscollins3456
Copy link
Collaborator

This PR extends the existing forms functionality from just datasets to all other entity types that have a classic profile page to display the forms CTA on.

The main changes are:

  1. fetch and map back the forms aspect on all of these entities in the GMS/GraphQL layer
  2. update entities so we can get their sidebars for the forms modal

Finally, this PR does one extra thing which is removes onboarding steps for forms that should not be there. These are for a bulk experience that does not exist (yet).

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Feb 8, 2024
Copy link
Contributor

@samblackk samblackk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving changes to datahub-web-react

@chriscollins3456 chriscollins3456 merged commit ea4a9b2 into datahub-project:master Feb 13, 2024
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants