Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest/glossary): handle ownership type in business glossary connector #9805

Merged
merged 2 commits into from
Feb 9, 2024
Merged

feat(ingest/glossary): handle ownership type in business glossary connector #9805

merged 2 commits into from
Feb 9, 2024

Conversation

sgomezvillamor
Copy link
Contributor

this handles both custom ownership types and values from enum

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@sgomezvillamor
feat(ingest/glossary): handle ownership type in business glossary con…
1600c0a 
…nector

handles both custom ownership types and values from enum
@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community datahub-community-champion PRs authored by DataHub Community Champions labels Feb 9, 2024
@sgomezvillamor sgomezvillamor mentioned this pull request Feb 9, 2024
Closed
5 tasks
@sgomezvillamor sgomezvillamor marked this pull request as ready for review February 9, 2024 17:22
hsheth2
hsheth2 approved these changes Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsheth2 hsheth2 merged commit 93a7afb into datahub-project:master Feb 9, 2024
54 checks passed
@sgomezvillamor sgomezvillamor deleted the feat-ingest-glossary-ownership-type branch February 12, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community datahub-community-champion PRs authored by DataHub Community Champions ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgomezvillamor @hsheth2