feat(ui/ingest): ingestion form for Okta and AzureAD #9829
Conversation
github-actions
bot
added
product
There was a problem hiding this comment.
going to approve assuming that the fields we have here are what ingestion team would recommend but the frontend implementation looks good!
the main change before merging is to bring the copied function into a shared utility file. I'm approving anyways because I don't want to block once that change is made.
| @@ -0,0 +1,174 @@ | |||
| import { RecipeField, FieldType, setListValuesOnRecipe } from './common'; | |||
|
|
|||
| const validateURL = (fieldName) => { | |||
There was a problem hiding this comment.
it looks like this function was copied from csv.ts - let's bring that function to a new shared utils.ts file and import it in the three recipes instead of copying it twice.
Then, it would be nice to have unit tests on that utility function
anshbansal
changed the title
asikowitz
removed
the
community-contribution
| tooltip: 'Which Okta User Profile attribute to use as input to DataHub username mapping. Common values used are - login, email.', | ||
| type: FieldType.TEXT, | ||
| fieldPath: 'source.config.okta_profile_to_username_attr', | ||
| placeholder: 'usename', |
There was a problem hiding this comment.
Change this to be email instead.
Add another option for okta_profile_to_username_regex
Move both to Advanced section
There was a problem hiding this comment.
"Can I change source.config.okta_profile_to_username_attr to source.config.email, or is it only the placeholder that needs to be changed? Additionally, should I move the okta_profile_to_username_regex in advance section or filter section?
| import { validateURL } from '../../utils'; | ||
| import { RecipeField, FieldType, setListValuesOnRecipe } from './common'; | ||
|
|
||
| export const OKTA_DOMAIN_URL: RecipeField = { |
There was a problem hiding this comment.
Add option for stateful_ingestion. Only need to add stateful_ingestion.enabled in Advanced section.
There was a problem hiding this comment.
Add option for skip_users_without_a_group
| import { validateURL } from '../../utils'; | ||
| import { RecipeField, FieldType, setListValuesOnRecipe } from './common'; | ||
|
|
||
| export const AZURE_CLIENT_ID: RecipeField = { |
There was a problem hiding this comment.
Add option for stateful ingestion in advanced section
…a and AzureAD
Checklist